This repository was archived by the owner on Jun 13, 2025. It is now read-only.
feat: Add ACH payment method #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
9f023ab to
058e85f
Compare
Codecov ReportAttention: Patch coverage is
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 96.09% 96.08% -0.01%
==========================================
Files 829 832 +3
Lines 19384 19459 +75
==========================================
+ Hits 18627 18698 +71
- Misses 757 761 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
02cfe7f to
fea79e0
Compare
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
fea79e0 to
0d80364
Compare
suejung-sentry
changed the title
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
2 times, most recently
from
834f022 to
fd0f925
Compare
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
fd0f925 to
5301ad6
Compare
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
codecov_auth/commands/owner/interactors/create_stripe_setup_intent.py
Outdated
Show resolved
Hide resolved
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
ajay-sentry
reviewed
Jan 14, 2025
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
aa6df89 to
71d2628
Compare
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
71d2628 to
86999ee
Compare
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
86999ee to
8ea30ac
Compare
ajay-sentry
reviewed
Jan 15, 2025
ajay-sentry
reviewed
Jan 15, 2025
ajay-sentry
reviewed
Jan 15, 2025
ajay-sentry
approved these changes
Jan 15, 2025
Contributor
ajay-sentry
left a comment
ajay-sentry
left a comment
There was a problem hiding this comment.
lgtm! Just two more minor nits
suejung-sentry
force-pushed
the
sshin/stripe-setup-intent
branch
from
2829141 to
530136c
Compare
This was referenced Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does below to add compatibility for ACH payment method.
PaymentElement(formerly using theCardElementthat does not require this).CheckoutSessionand the newPaymentElement. If not specified, it uses the Default in the stripe dashboard.should_propagateknob on the existingupdate_emailapi as the ACH payment method requires an associated billing_email (where it was optional on credit card). With our UI designs, we specify email in a separate component, so have that component propagate the info to the default_payment_method using this updated api.The changes to these apis are all backwards compatible so can go in before any UI changes go live.
Part of this project: codecov/engineering-team#2622
Closes codecov/engineering-team#3115
Closes codecov/engineering-team#3114
Closes codecov/engineering-team#3110